Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvment of traditional representation #1519

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

merfort
Copy link
Contributor

@merfort merfort commented Jan 11, 2024

Purpose of this PR

This PR prevents a spillover of traditional biomass into other sectors (i.e. the industry sector), by ensuring that not more pebiolc is transformed into sesobio via biotr than there is demand for solid biomass in buildings. This applies only to regions that still have a traditional biomass demand.

In order to do that, the phase-out trajectory of vm_deltaCap(t ,regi, "biotr","1") is relaxed from a fixed value to an upper bound. This works, because biotr is by definition the cheapest and most efficient technology, so REMIND will always use that technology if not constrained otherwise.

The effect is, that IND and SSA now have lower levels of vm_prodSe(t,regi,"pebiolc","sesobio","biotr") and the solids demand is instead fulfilled with coal (coaltr) and modern solid biomass (biotrmod).

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed (not needed)
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches (not needed)
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
    /p/tmp/merfort/REMIND_update_residues/remind
  • Comparison of results (what changes by this PR?):
    You find a compare scenarios PDF here:
    /p/tmp/merfort/REMIND_update_residues/remind/compScen-orig_vs_relax_biotr_supply_v2-2024-01-11_08.50.31-H12.pdf
    Differences between the previous version ("orig") and the new version ("relax_biotr_supply_v2") are small. Biggest difference is that some of the solids that came from traditional biomass before is now coming from coal or (modern) biomass in IND and SSA:
    image
    image
    image
    image

@merfort
Copy link
Contributor Author

merfort commented Jan 11, 2024

@robinhasse Could you have a look at this? In particular, codeCheck reminded me of the fact that I did not add the new condition preventing the spillover also to the other realizations. What is the process here, should we also keep services_putty and services_with_capital updated?

Copy link
Contributor

@robinhasse robinhasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @merfort. No need to consider the other realisations. They are about to be removed.

modules/36_buildings/simple/declarations.gms Outdated Show resolved Hide resolved
@merfort merfort marked this pull request as ready for review January 18, 2024 13:36
@tabeado
Copy link
Contributor

tabeado commented Jan 18, 2024

Thanks for taking care of this Leon!
I just remember that we talked about adjusting the lifetime of biotr as well, as it is currently set to 35 years. Did you have a look at this/ do we want to consider it as a separate issue?

@merfort
Copy link
Contributor Author

merfort commented Jan 18, 2024

Thanks for taking care of this Leon! I just remember that we talked about adjusting the lifetime of biotr as well, as it is currently set to 35 years. Did you have a look at this/ do we want to consider it as a separate issue?

Ah, right. No, I haven't yet. I would consider this a separate issue.

modules/36_buildings/simple/equations.gms Outdated Show resolved Hide resolved
@merfort merfort merged commit ac2b048 into remindmodel:develop Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants