Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify capitalization of variables and parameters #1542

Merged
merged 13 commits into from
Feb 28, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Feb 5, 2024

Purpose of this PR

Unifies capitalization of variables an parameters so that REMIND passes soon-to-be introduced codeCheck

Whenever possible, the code uses the capitalization as declared in declarations.gms and sets.gms.

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • All automated model tests pass (FAIL 0 in the output of make test)

@fbenke-pik fbenke-pik marked this pull request as ready for review February 20, 2024 15:32
Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you also check the scripts part of teh GAMS repo and that the reporting is still working?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… adding insult to injury asking me to approve this.

@fbenke-pik
Copy link
Contributor Author

fbenke-pik commented Feb 23, 2024

Nah, I added you to give you the chance to raise concerns / stop this before this is merged (also, because it affects the industry module a lot).

@fbenke-pik fbenke-pik merged commit 273d50b into remindmodel:develop Feb 28, 2024
2 checks passed
@fbenke-pik fbenke-pik deleted the variables branch February 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants