-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify capitalization of variables and parameters #1542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you also check the scripts part of teh GAMS repo and that the reporting is still working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… adding insult to injury asking me to approve this.
Nah, I added you to give you the chance to raise concerns / stop this before this is merged (also, because it affects the industry module a lot). |
Purpose of this PR
Unifies capitalization of variables an parameters so that REMIND passes soon-to-be introduced codeCheck
Whenever possible, the code uses the capitalization as declared in declarations.gms and sets.gms.
Type of change
Checklist:
remind2
where it was neededFAIL 0
in the output ofmake test
)