delete realization complex of module 35_transport #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cleaningRealizations
…cleaningRealizations
…t, apcardiEffH2t and uedit, uepet, ueelt * delete q40_EV_share, p40_EV_share and pm_boundCapEV * delete realization EVmandates of module 40_techpol
robertpietzcker
approved these changes
Feb 8, 2024
core/sets.gms
Outdated
| @@ -343,6 +331,14 @@ $ENDIF.WindOff | |||
| seceaf "Route: Scrap-loaded EAF" | |||
| pcc "outdated technology, only here to avoid compilation errors if input data containing information for this technology are used" | |||
| pco "outdated technology, only here to avoid compilation errors if input data containing information for this technology are used" | |||
| *** transport technologies for deleted realization complex of module 35_transport - only here for input data consistency | |||
There was a problem hiding this comment.
maybe not "input data consistency", but rather "to make it possible to process input data that still includes data for these obsolete transport technologies"?
Renato-Rodrigues
requested changes
Feb 8, 2024
main.gms
Outdated
| @@ -1448,18 +1437,18 @@ $setglobal cm_incolearn off !! def = off | |||
| $setglobal cm_storageFactor off !! def = off | |||
| *** cm_learnRate "change learn rate value by technology." | |||
| *** def <- "off" = no change for learn rate value; | |||
| *** or list of techs to change learn rate value. (ex. "apcarelt 0.2") | |||
| *** or list of techs to change learn rate value. | |||
There was a problem hiding this comment.
I would keep an example here, but use another tech, e.g. spv
There was a problem hiding this comment.
please provide a good example. I don't know one
main.gms
Outdated
| $setglobal cm_learnRate off !! def = off | ||
| *** cm_adj_seed and cm_adj_seed_cont "overwrite the technology-dependent adjustment cost seed value. Smaller means slower scale-up." | ||
| *** both swicthes have the same functionality, but allow more changes once the character limit of cm_adj_seed is reached. | ||
| *** def <- "off" = use default adj seed values. | ||
| *** or list of techs to change adj_seed value. (ex. "apCarH2T=0.5,apCarElT=0.5,apCarDiEffT=0.25,apCarDiEffH2T=0.25") | ||
| *** or list of techs to change adj_seed value. |
There was a problem hiding this comment.
again, I would keep an example using other technologies.
There was a problem hiding this comment.
please provide a good example. I don't know one
There was a problem hiding this comment.
(ex "spv=1, tnrs = 0.1")
main.gms
Outdated
| $setglobal cm_adj_seed off | ||
| $setglobal cm_adj_seed_cont off | ||
| *** cm_adj_coeff and cm_adj_coeff_cont "overwrite the technology-dependent adjustment cost coefficient. Higher means higher adjustment cost." | ||
| *** both swicthes have the same functionality, but allow more changes once the character limit of cm_adj_coeff is reached. | ||
| *** def <- "off" = use default adj coefficient values. | ||
| *** or list of techs to change adj_coeff value. (ex. "apCarH2T=100,apCarElT=100,apCarDiEffT=200,apCarDiEffH2T=200") | ||
| *** or list of techs to change adj_coeff value. |
There was a problem hiding this comment.
again, I would keep an example using other technologies.
There was a problem hiding this comment.
(ex. "gash2=1, hydro=0.1")
Renato-Rodrigues
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
cleaning: delete realization complex of module 35_transport and all related code parts
Type of change
Checklist:
FAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information (optional):