Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ar6Climate -> MAGICC7_AR6, add cs2 section with all output #1615

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Mar 14, 2024

Purpose of this PR

  • rename ar6Climate -> MAGICC7_AR6. It needs mif files, so add it in output.R to that category
  • shorten variable names
    AR6 climate diagnostics|Surface Temperature (GSAT)|MAGICCv7.5.3|67.0th Percentile
 -> MAGICC7 AR6|Surface Temperature (GSAT)|67.0th Percentile
  • add own section that allows to see full MAGICC7 output in compareScenarios2 style, using the new plotPercentiles function introduced by @tonnrueter. See /p/tmp/oliverr/remind/compScen-fulltest_MAGICC7_AR6-2024-03-14_15.07.59-MAGICC7_AR6.pdf
  • Gross Emissions|CO2 is also a variable that contains bunkers only at the global level, so it must be skipped in aggregation checks
  • rename project_interfaces -> piamInterfaces

Type of change

  • New feature
  • Bug fixes

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test): [ FAIL 0 | WARN 0 | SKIP 6 | PASS 80 ]
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters merged commit 36fad90 into remindmodel:develop Mar 14, 2024
2 checks passed
@orichters orichters deleted the smallfix4 branch March 18, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants