-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance calibration report #1671
Conversation
4694689
to
4c528d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One point: My original script does some shuffling to get the production factors in a sensible order in the plots.
pf_order <- read_lines(file = CES_cal_file, n_max = 1)
if (grepl('^# pf order:', pf_order)) {
pf_order <- pf_order %>%
sub('^# pf order: ', '', .) %>%
strsplit(', ') %>%
unlist()
} else {
pf_order <- d %>%
pull('pf') %>%
unique()
}
d <- d %>%
order.levels(pf = pf_order)
The result is that production factors within the same CES nest are grouped together in the plot
instead of alphabetical order, which is rather meaningless
Thank you for this, very helpful. I still have some comments:
|
This is not an empty section, it is the heading for all the plots that follow. I have to introduce a page break, because the line plots in these section need all the space of the page, otherwise the formatting goes wrong and swallows a plot. So this is a know inconvenience that won't go away. The heading is there to allow jumping in the table of contents. |
You have a 2nd-level heading ( |
I see, I adjusted the headings again. |
I adjusted the regions sorting to alphabetical order in the first set of plots as well, so they are unified now. |
The report can be found here: Would any of these palettes fit better? (I picked one of the Diverging sections, "Purple-Green") https://colorspace.r-forge.r-project.org/reference/hcl_palettes.html But yeah, happy to implement any specific instruction you find useful (I am lacking the user perspective here) |
I had a look and in terms of contrast I think I like the green-orange one best. These are the palettes with 10 different colors for reference: |
I really like this, I think it is now very clearly visible which one is the final iteration and that (in this case) it closely matches the target. |
Purpose of this PR
Enhance output script
reportCEScalib
to include additional plot formats (credit goes to @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q). Moved code to a Rmarkdown file.An example of the new pdf report can be found here:
/p/tmp/ricardar/remind/remind-develop/remind/output/SSP2EU-NPi-calibrate_2024-03-21_12.23.31/CES_calibration_report_SSP2EU-NPi-calibrate.pdf
Type of change
Checklist:
FAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly