Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for exogenous CO2 prices from reference gdx #1698

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Renato-Rodrigues
Copy link
Member

@Renato-Rodrigues Renato-Rodrigues commented Jun 11, 2024

Purpose of this PR

  • add support for defining exogenous CO2 prices from the reference gdx.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly
  • Adapt the reporting to correctly display the exogenous defined CO2 prices

Further information (optional):

  • Test runs are here:
    /p/projects/ecemf/tmp/test_exogenousPriceFromGDX/output/force_co2_2024-06-11_19.34.05

@Renato-Rodrigues Renato-Rodrigues marked this pull request as ready for review June 11, 2024 18:45
Copy link
Contributor

@ricardarosemann ricardarosemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for implementing this :-)

@LaviniaBaumstark
Copy link
Member

Why is this PR still open?

@Renato-Rodrigues
Copy link
Member Author

It requires remind reporting changes that were still not implemented as described in the unchecked item in the check list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants