Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MAGICC7 variables to reference run #1744

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Jul 15, 2024

Purpose of this PR

  • somehow, MAGICC7 does not produce the exact same output as the reference run for all timesteps before cm_startyear, see less /p/projects/remind/modeltests/remind/output/SSP2-PkBudg650-AMT_2024-07-11_14.44.30/log.txt.
  • Many of the deviations are very small, well below 1%, while some specific Aerosol Forcing variables in the 90th percentile are as big as 40%.
  • part of https://github.com/remindmodel/development_issues/issues/220

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test): [ FAIL 0 | WARN 0 | SKIP 6 | PASS 83 ]
  • The changelog CHANGELOG.md has been updated correctly

@LaviniaBaumstark
Copy link
Member

why is this PR still open?

Copy link
Contributor

@gabriel-abrahao gabriel-abrahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still haven't managed to find out why this is happening, but for the time being, just fixing should be good enough.

@gabriel-abrahao gabriel-abrahao merged commit a92387a into remindmodel:develop Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants