shift unit from US$2005 to US$2017 #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and p32_flex_maxdiscount
…GDPaPOPaSSP2 convert p36_CESMkup and pm_tau_pe_tax from 2005$US to 2017$US and delete p21_tau_pe2se_inconv
…S$2005 to US$2017
…t conversion factor for inco0
gabriel-abrahao
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
The MACCs conversion looks right to me, pending @fbenke-pik 's removal of the incorrect conversion in the updated mrcommons::convertImageMacc().
orichters
reviewed
Sep 16, 2024
core/declarations.gms
Outdated
| @@ -605,9 +597,12 @@ s_MtCO2_2_GtC "conversion factor from Mt | |||
|
|
|||
| s_MtCH4_2_TWa "Energy content of methane. MtCH4 --> TWa: 1 MtCH4 = 1.23 * 10^6 toe * 42 GJ/toe * 10^-9 EJ/GJ * 1 TWa/31.536 EJ = 0.001638 TWa (BP statistical review)" /0.001638/ | |||
|
|
|||
| sm_h2kg_2_h2kWh "convert kilogramme of hydrogen to kwh energy value." /32.5/ | |||
| s_D2015_2_D2017 "Convert $2015 to $2017" /1.0292/ | |||
There was a problem hiding this comment.
Great, a new type style, as USD, US$, US, USD_ and EUR, EUR_ used in our output files were not enough 🥳
| p02_inconvpen_lap(ttot,regi,te)$(ttot.val ge 2005) = p02_inconvpen_lap(ttot,regi,te) * 4.3 * 1E-4; !! this is now equivalent to 1$/GJ at 1000$/per Capita in the welfare logarithm | ||
| p02_inconvpen_lap(ttot,regi,te)$(ttot.val ge 2005) = p02_inconvpen_lap(ttot,regi,te) * (1/sm_giga_2_non) / sm_GJ_2_TWa; !! conversion util/(GJ/cap) -> util/(TWa/Gcap) | ||
| *RP* these values are all calculated on seprod level. | ||
| display p02_inconvpen_lap; | ||
| $ENDIF.INCONV | ||
|
|
||
| *BS* 2020-03-12: additional inputs for inequality | ||
| * To Do: rename file, then also in "files" and moinput::fullREMIND.R | ||
| *** To Do: rename file, then also in "files" and moinput::fullREMIND.R |
There was a problem hiding this comment.
Great you adjusted the Todo that refers to some moinput package that I have never heard of.
| @@ -115,20 +104,7 @@ $ifThen.SEtaxRampUpParam not "%cm_SEtaxRampUpParam%" == "off" | |||
| ); | |||
| $endif.SEtaxRampUpParam | |||
|
|
|||
| ***cb 20110923 load paths for ressource export taxes | |||
There was a problem hiding this comment.
that option was just deleted?
| @@ -83,19 +83,6 @@ p32_shThresholdTotVREAddIntCost(t)$(t.val > 2045) = 95; | |||
|
|
|||
| p32_FactorAddIntCostTotVRE = 1.5; | |||
|
|
|||
| $ontext | |||
There was a problem hiding this comment.
what was the purpose of that code, anyway?
…GDPaPOPaSSP2 fix bug in transport data loaded in presolve.gms but need no unit shift as they are now provided in US42017
* add min. version of R-packages * update to input data version 6.95
LaviniaBaumstark
changed the title
…SSP1, SDP_MC, SSP2_lowEn and SSP5 (calibration runs: /p/tmp/lavinia/REMIND/REMIND_calibration_unitShift_2024_09_21/remind)
dklein-pik
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Shift the unit of all monatary parameters and variables in REMIND to a new unit (i.e. form $US2005 to US$2017).
Most of the changes happened in the input data generation and therefore a new input data revision and minimum R-package versions are required.
Where hard coded monetary values are used in GAMS, conversion factors are introduced: s_D2015_2_D2017, sm_D2005_2_D2017, sm_D2020_2_D2017, sm_EURO2023_2_D2017
Type of change
Checklist:
remind2where it was neededFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information (optional):