createPath no longer prefixes "search" and "hash" parameters

[panta82]

During the transition to typescript, createPath function has changed from this:

function createPath(location) {
  var pathname = location.pathname,
      search = location.search,
      hash = location.hash;
  var path = pathname || '/';
  if (search && search !== '?') path += search.charAt(0) === '?' ? search : "?" + search;
  if (hash && hash !== '#') path += hash.charAt(0) === '#' ? hash : "#" + hash;
  return path;
}

to this

export function createPath({
  pathname = '/',
  search = '',
  hash = ''
}: PartialPath) {
  return pathname + search + hash;
}

You are no longer ensuring that passed search and hash are prefixed, which kind of broke our site.

You should either restore the old behavior or document the breaking change.

[chaance]

Added to the Breaking Changes section in our v5 release notes. Thank you for flagging this, very sorry for the breakage! https://github.com/remix-run/history/releases/tag/v5.0.0

EDIT: Jk, we actually should just revert this here and consider the change a bug. So that's what I'm going to do!