Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Constant Domain History #962

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

JelleRoets-Work
Copy link

@JelleRoets-Work JelleRoets-Work commented Oct 5, 2022

This PR adds a new 'Constant Domain History' object.

Why

Currently when navigating back and forth with the history object, you don't know upfront where this will bring you. So you might as well end up on a different domain, which is often unexpected / unwanted.

What

The newly added history object prevents going back to a different domain.

How

By setting a fromDomain flag in the history state. See the extended docs in this PR for further details.

Impact

It slightly modifies the existing interface of the History object, but it is still backwards compatible. The navigation functions now return a boolean if the navigation was blocked or not.

State

This is an initial PR, I don't expect it to get merged as is, but I'd love to gain some feedback / insights from the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant