shouldUpdateScroll must be component instance hook

[klimashkin]

Hello!
I have Route which handle photo gallery. This gallery have many parameters: page number (url parameter), filter and scroll (query parameters)
For example: /gallery/5?filter=1&sort=-5 means, fifth page, some filter and some descending sort
So, when user change page, he expect scroll change like browser page navigation, but when he toggle buttons for filter or sort, scroll should not be changed.

Variants of parameter combinations can be many different, so need a hook shouldUpdateScroll, which will be called after willTransitionTo and componentWillRecieveProps, when something in uri changes.

As I understand, the new variable ignoreScrollBehavior will not help me in described case

[ryanflorence]

interesting, either that, or toss query/params/route info to the scroll behavior and you can write a scroll behavior that factor's this stuff in.

[gaearon]

I also need this to support :userId/posts/?limit=number.

Can we make it that changing just query implicitly (and always) opts you out of scroll behavior?

I find it hard to image a case where you want to change query but reset scroll. Even if you need this, you can always promote your query to be a proper parameter, and then you have finer control.

[mjackson]

@gaearon Is this fixed?

[gaearon]

@mjackson With #522, we don't update scroll on query-only changes.

[mjackson]

@klimashkin I believe #522 addresses your original use case. When the route params change, the scroll is updated. When only the query changes, we don't touch the scroll. Please feel free to continue the conversation and we can re-open this issue if you need something more. :)