Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): re-use REMIX_DEV_SERVER_WS_PORT when reloading config #3206

Merged
merged 5 commits into from
May 17, 2022
Merged

fix(remix-dev): re-use REMIX_DEV_SERVER_WS_PORT when reloading config #3206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b9ad25
fix(remix-dev): re-use REMIX_DEV_SERVER_WS_PORT when reloading config
mcansh May 16, 2022
a600343
chore(remix-dev): NaN fallback
mcansh May 17, 2022
0ea0631
Update packages/remix-dev/config.ts
mcansh May 17, 2022
14963ea
Update packages/remix-dev/config.ts
kentcdodds May 17, 2022
f338584
Update packages/remix-dev/config.ts
kentcdodds May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/remix-dev/__tests__/readConfig-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,9 @@ describe("readConfig", () => {
`
);
});

it("returns the same devServerPort value across reloads", async () => {
let newConfig = await readConfig(remixRoot);
expect(newConfig.devServerPort).toBe(config.devServerPort);
});
});
7 changes: 1 addition & 6 deletions packages/remix-dev/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,12 +353,7 @@ export async function readConfig(
path.join("public", "build")
);

if (typeof appConfig.devServerPort !== "number") {
appConfig.devServerPort = Number(
process.env.REMIX_DEV_SERVER_WS_PORT || 8002
);
}
let devServerPort = await getPort({ port: appConfig.devServerPort });
let devServerPort = Number(process.env.REMIX_DEV_SERVER_WS_PORT) || await getPort({ port: Number(appConfig.devServerPort) || undefined });
// set env variable so un-bundled servers can use it
process.env.REMIX_DEV_SERVER_WS_PORT = `${devServerPort}`;
let devServerBroadcastDelay = appConfig.devServerBroadcastDelay || 0;
Expand Down