tests(remix-react): add failing test for default Form action

[ionut-botizan]

Issue: #3133

The default <Form /> action should match the current location. Currently, only the path is preserved, but the search parameters are lost.

E.g. For the /login?redirectTo=/profile location and a <Form method="post" /> element, the generated form node looks like
<form method="post" action="/login">.

[remix-cla-bot]

Hi @ionut-botizan,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[chaance]

A few changes needed before we can merge. If an action value of . is provided, it is correct to strip the search params when resolving the route path. We only need to preserve the location's search if no action is provided.

[maranomynet]

Please someone resolve and merge this PR.

Always having to do this feels so daft.

const { pathname, search } = useLocation();

return <Form action={pathname+search}

[ionut-botizan]

Hey guys! Are there any other changes or additions that you would like me to provide? I think I did everything that was asked in the initial review...
I don't mean to bother you. I realize there are more important issues out there I was just thinking that maybe you missed the fact that I responded to the review. 🙂

[chaance]

Hi @ionut-botizan, sorry for the radio silence on this one. We actually have duplicated efforts a bit on this bug. We are building Remix's form components and hooks into React Router, so @brophdawg11 and I have been working in tandem on that separately. I think I must have forgotten about your work and started my own over in #3697. Very sorry about that.

To clean things up, I'm going to close this one. But I added you as a co-committer for 783c435 (#3697) and made sure your handle is included in the contributor list. I definitely want to make sure you're credited with identifying the problem and proposing the initial fix!