-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-dev): support multiple nested pathless layout routes #3331
Conversation
Hi @pokedotdev, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Co-authored-by: Michaël De Boey <[email protected]>
|
@MichaelDeBoey is this PR still to approve? |
Oh interesting, I didn't know we had a separate PR for this. This is also fixed by #4421 which was initially addressing #3014 but uncovered this same issue during testing. I think I lean towards the solution in #4421 since rather than mess with the It may make sense to keep the integration tests from this PR even if we go with #4421 - I'll take a closer look and make sure we're properly covered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a small thing regarding the slug index & foo layout
test
Co-authored-by: Tyler Cosgrove <[email protected]>
This got a bit outdated -- very sorry it took us a bit to follow up. As @brophdawg11 mentioned this should have been taken care of already, and most of the logic has been moved to React Router. If there is still an issue I'd suggest opening one in that repo so we can give it a fresh look. |
Closes: #3327