fix(remix-react): fix <Form> submit to not break formMethod functionality

[nrako]

Closes: #2162 (supersede) – credits to @mdoury for his original PR

the <Form> component – unlike native <form> - does not respect the formmethod attribute set
on the submitter (the button submitting the form).

• Docs N/A
• Tests

Testing Strategy:

<Form method="post">
  <input name="eat" value="pizza" />
  <button type="submit"> Submit with GET </button>
</Form>
// should submit with a GET to `/?eat=pizza` but instead do a POST

See integration Bug-Report-Test via commit: 37b0140

---

test: failing test with <Form> not respecting formMethod
06333c1 <Nicholas Rakoto> Thu, 30 Jun 2022 00:33:15 +0200

Bug report integration test demonstrating how the `<Form>` component – 
unlike native `<form>` - does not respect the `formmethod` attribute set on
the submitter (the `<button>` submitting the form).

fix(remix-react): submit <Form> w/method set by submitter formmethod
bfd1f88 <Nicholas Rakoto> Thu, 30 Jun 2022 00:32:22 +0200

Fix `<Form>` component by not passing the form's `method` into the
`options` when calling the `submit(target, options)` function (created with
the `useSubmit()` hook). This ensures that the option does not take 
precedence on any `formethod` set on the submitter which otherwise break the
`formmethod` functionality.

Since #3094 and #3094 the `<Form>` passes the "submitter" (if any) as the
`target` to the `submit(target, options)` (`useSubmitImpl`) which will
attempt to read the `formmethod`, `formaction` and `formenctype` attributes
on the target. Therefore, the responsability to infer which method should be
used should solely be on `useSubmitImpl` for the given
`target`.

Co-authored-by: Maxime Doury <[email protected]>

[MichaelDeBoey]

Could you maybe add the other tests from #2162 as well please?

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[nrako]

@MichaelDeBoey – could you please be a bit more explicit about the "other tests". The tests in this PR specifically cover what is fixed, which is to ensure that the formethod on a submit button is not ignored. The only other test I see in the PR is one that more or less verify that a <Form> submit with the method specified which I believe is already covered by many other existing tests.

Note: I've refactored the tests a bit, fixed the failing test, put the tests under a new describe and split the assertions in two different tests for both POST and GET.

[evanstern]

Any movement on this? Is there any way I can help get this across the finish line?

[MichaelDeBoey]

@nrako The tests in #2162 have split tests for using the form method attribute, the button formmethod attribute & combined, you only have tests for the combined case

[nrako]

@MichaelDeBoey – well yes, but as I mentioned:

The only other test I see in the PR is one that more or less verify that a <Form> submit with the method specified which I believe is already covered by many other existing tests.

I personally don't believe that it is the responsibility of this PR to add tests coverage for something which is unrelated to what this PR fix and is also already covered by other tests.

But feel free to add them, Remix's maintainers have edit privilege on my PR/branch. If I get a quick reply that can change my mind I might try to follow up on it but to get expectation clear, I'll soon be off for vacations.

[evanstern]

If someone can give me some instructions on how I can make these changes, I'd be happy to make them so this can get merged. This is functionality that I desperately need for my project.

[kevlened]

I opened a PR at #4053 that adds the tests from #2162

[MichaelDeBoey]

Closing this one in favor of #4053