Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev): suport handle in frontmatter #4865

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Dec 14, 2022

Closes: #4864

  • Docs
  • Tests

Testing Strategy: tested locally with my own application.

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

🦋 Changeset detected

Latest commit: 33aa216

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev December 14, 2022 20:07
@MichaelDeBoey MichaelDeBoey changed the title Handle frontmatter feat(remix-dev): suport handle in frontmatter Dec 14, 2022
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Dec 14, 2022
Titles are now specified hierarchically; each page exports a
"breadcrumb" and the title is constructed from the concatenation
of the page's breadcrumb and the breadcrumbs of all of its
ancestors.

Note: in the future, we will be able to specify breadcrumbs in
Markdown frontmatter. See remix-run/remix#4865.
@lpsinger
Copy link
Contributor Author

lpsinger commented Jan 3, 2023

Ping...

@MichaelDeBoey
Copy link
Member

@lpsinger The team is having its holiday break now, so they'll get to this when they're back and they have some time

@MichaelDeBoey
Copy link
Member

@lpsinger It seems like you broke our integration tests with this update. Could you please fix them again?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Jan 4, 2023
@lpsinger
Copy link
Contributor Author

lpsinger commented Jan 4, 2023

Fixed now.

@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label Jan 4, 2023
@mcansh mcansh merged commit 512d655 into remix-run:dev Jan 6, 2023
@lpsinger lpsinger deleted the handle-frontmatter branch January 6, 2023 19:04
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-512d655-20230107 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants