Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(remix-architect): use @architect/functions' built-in types #4898

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Dec 16, 2022

As of @architect/[email protected], types are included in the package itself and there is no longer a need for
@types/architect__functions.

  • Docs (N/A)
  • Tests (no need for new tests; if the CI pipeline passes, then it's fine)

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022

🦋 Changeset detected

Latest commit: 322d2ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
remix Patch
@remix-run/architect Patch
create-remix Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lpsinger lpsinger force-pushed the architect-functions-types branch 2 times, most recently from 15e3662 to 828b2ee Compare December 16, 2022 22:28
@MichaelDeBoey MichaelDeBoey changed the title chore(deps): use @architect/functions built-in types refactor(remix-architect): use @architect/functions' built-in types Dec 16, 2022
@lpsinger
Copy link
Contributor Author

lpsinger commented Jan 2, 2023

Any updates?

lpsinger and others added 2 commits January 3, 2023 08:28
As of @architect/[email protected], types are included in the
package itself and there is no longer a need for
@types/architect__functions.
@mcansh
Copy link
Collaborator

mcansh commented Jan 3, 2023

hey sorry! we just got back from holiday break - reviewing now

@mcansh mcansh merged commit 768db36 into remix-run:dev Jan 3, 2023
@lpsinger lpsinger deleted the architect-functions-types branch January 3, 2023 22:27
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-2c398e4-20230104 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants