Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix version script #4925

Merged
merged 1 commit into from
Jan 22, 2023
Merged

chore: fix version script #4925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ async function updateRemixVersion(packageName, nextVersion, successMessage) {
config.devDependencies[`@remix-run/${pkg}`] = nextVersion;
}
if (config.peerDependencies?.[`@remix-run/${pkg}`]) {
config.peerDependencies[`@remix-run/${pkg}`] = nextVersion;
let isRelaxedPeerDep =
config.peerDependencies[`@remix-run/${pkg}`]?.startsWith("^");
config.peerDependencies[`@remix-run/${pkg}`] = `${
isRelaxedPeerDep ? "^" : ""
}${nextVersion}`;
Comment on lines +111 to +115
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaance loosened this in #4736 for @remix-run/dev

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll defer to @chaance on this :)

}
}
});
Expand Down Expand Up @@ -172,7 +176,8 @@ const updateDenoImportMap = async (importMapPath, nextVersion) => {
let [packageName, importPath] =
getPackageNameFromImportSpecifier(importName);

return remixPackagesFull.includes(packageName)
return remixPackagesFull.includes(packageName) &&
importName !== "@remix-run/deno"
Comment on lines +179 to +180
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remix-run/deno code is already a Deno module, so just get types for it directly from node_modules/

remix/templates/deno/.vscode/resolve_npm_imports.json

Lines 10 to 11 in d5ca496

"// `@remix-run/deno` code is already a Deno module, so just get types for it directly from `node_modules/`": "",
"@remix-run/deno": "../node_modules/@remix-run/deno/index.ts",

? [
importName,
`https://esm.sh/${packageName}@${nextVersion}${
Expand Down