refactor(remix-dev): replace @esbuild-plugins/node-modules-polyfill with esbuild-plugin-polyfill-node
#5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Jan 26, 2023
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
from
d4c4b11
to
698ed2a
Compare
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
from
698ed2a
to
5317907
Compare
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
from
5317907
to
318dcc3
Compare
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
4 times, most recently
from
a04419e
to
4495004
Compare
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
2 times, most recently
from
6535ba8
to
2b8d3df
Compare
This was referenced Mar 27, 2023
|
Hello @MichaelDeBoey , Do you know when this PR will be merged? Best regards |
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
4 times, most recently
from
280b031
to
455abd5
Compare
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
2 times, most recently
from
da6285c
to
909356f
Compare
MichaelDeBoey
changed the title
@esbuild-plugins/node-modules-polyfill package@esbuild-plugins/node-modules-polyfill with esbuild-plugin-polyfill-node
… with `esbuild-plugin-polyfill-node`
MichaelDeBoey
force-pushed
the
update-esbuild-plugins-node-modules-polyfill-package
branch
from
909356f
to
b5ab62b
Compare
|
Thanks @MichaelDeBoey |
MichaelDeBoey
deleted the
update-esbuild-plugins-node-modules-polyfill-package
branch
|
🤖 Hello there, We just published version Thanks! |
1 task
1 task
This was referenced May 2, 2023
|
@MichaelDeBoey still not good replacement
|
|
@TrySound If you can come up with a better solution here, we're happy to accept PRs! 🙏 |
1 task
This was referenced Aug 24, 2023
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this pull request
Mar 8, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this pull request
Mar 8, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this pull request
Mar 8, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
to cloudflare/workers-sdk
that referenced
this pull request
Mar 9, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead ``` Resolves #1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this pull request
Mar 13, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this pull request
Mar 16, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @remorses (the maintainer of
@esbuild-plugins/node-modules-polyfillin remorses/esbuild-plugins#29 (comment), we should useesbuild-plugin-polyfill-nodeinsteadThis will also remove some deprecation warnings when installing
@remix-run/dev& fixes some imports of built-in Node packagesCloses #4299