fix: use path.normalize to convert POSIX paths to OS-specific paths

[haines]

Closes: #5322

(from #5324): The build currently breaks when loading routes

ENOENT: no such file or directory, open '<root>/app/outes/<route file>'

Note it is trying to load from outes not routes!

The bug was introduced in #5266. By splitting and rejoining the paths, it drops the leading / on Unix-like systems, converting /Users/me/... to Users/me/.... However appDirectory still has a leading / so removing directory prefixes with slice drops one too many characters.

This PR resolves the issue by using path.normalize to covert / to \ on Windows, rather than splitting and rejoining the paths.

• Tests

Testing Strategy:

This test covers this code (sort of... the test mirrors the production code so does not expose the bug):

remix/packages/remix-dev/__tests__/flat-routes-test.ts

Line 141 in ebfa645

describe("should return the correct route hierarchy", () => {

[changeset-bot]

🦋 Changeset detected

Latest commit: 1050325

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@remix-run/dev	Patch
create-remix	Patch
@remix-run/css-bundle	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @haines,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[machour]

Hey @haines, could you target the dev branch instead ? 🙏🏼

[haines]

@machour done! Could you please re-approve the workflow run?

[sockthedev]

TIL 👍

[machour]

As far as I see, this PR is modifying a test already passing.
Could you revert that and add a new test case to verify what you're fixing instead? 🤔

[haines]

@machour the existing test just mirrors the production code, so the test has the same bug and it needs to be modified. The problem is that the test exercises the internal function flatRoutesUniversal (to avoid having to run against a real filesystem), but the bug occurs in flatRoutes.

I could rewrite the test to exercise flatRoutes instead, but that'd require writing the test files to the filesystem (in a temporary directory). What do you think?

[MichaelDeBoey]

Superseded by #5228

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-a024557-20230207 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!