Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fetcher.type and fetcher.submission #5691

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

brophdawg11
Copy link
Contributor

Deprecate fetcher.type and fetcher.submission

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: 77740fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 force-pushed the brophdawg11/deprecate-fetcher-type-submission branch from 028a467 to 77740fb Compare March 7, 2023 22:12
// These settings should make this behave like a normal object `type` field
configurable: true,
enumerable: true,
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only warn if they actually access type or submission

@brophdawg11 brophdawg11 merged commit 66607b5 into dev Mar 9, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/deprecate-fetcher-type-submission branch March 9, 2023 20:51
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 9, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-66b33a8-20230310 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed docs feat:routing renderer:react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants