Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle CSS bundle updates during HMR #5823

Merged
merged 25 commits into from
Mar 20, 2023

Conversation

markdalgleish
Copy link
Member

Closes: #5642

  • Docs
  • Tests

Testing Strategy:

I've added an update using CSS Modules to the HMR test.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: d089f9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/css-bundle Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish marked this pull request as draft March 17, 2023 01:29
@markdalgleish markdalgleish marked this pull request as ready for review March 19, 2023 21:16
@markdalgleish markdalgleish merged commit 47311e0 into dev Mar 20, 2023
@markdalgleish markdalgleish deleted the markdalgleish/css-bundle-hmr branch March 20, 2023 18:46
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 20, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-4d86674-20230321 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon bug Something isn't working CLA Signed package:css-bundle package:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants