Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-server-runtime): pass AppLoadContext to handleRequest #5836

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

fernandojbf
Copy link
Contributor

This is the same feature change request done here. A new discussion was created to this.

My action was mainly check the changes by introduced @axel-habermaier's PR and apply them again.

This is my first contribution, if i made something wrong please let me know.

Closes: #

  • Docs
  • Tests

Testing Strategy:

I've added unit tests on server-runtime passing loadContext to the handler.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

🦋 Changeset detected

Latest commit: 131a1c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/serve Patch
@remix-run/testing Patch
@remix-run/vercel Patch
remix Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 17, 2023

Hi @fernandojbf,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@fernandojbf fernandojbf force-pushed the load-context-in-request-handler branch 3 times, most recently from 6c4146c to 4769f1b Compare March 17, 2023 12:07
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 17, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@fernandojbf fernandojbf force-pushed the load-context-in-request-handler branch 2 times, most recently from cdb1066 to be5dc39 Compare March 21, 2023 19:09
@fernandojbf
Copy link
Contributor Author

Bahh, I've made a rebase from main :( i will fix that in a moment

@fernandojbf fernandojbf force-pushed the load-context-in-request-handler branch from be5dc39 to 2b1c91f Compare March 21, 2023 19:22
@fernandojbf
Copy link
Contributor Author

Rebased again :)

@MichaelDeBoey MichaelDeBoey changed the title feat(server-runtime): pass AppLoadContext to handleRequest feat(remix-server-runtime): pass AppLoadContext to handleRequest Mar 22, 2023
@fernandojbf fernandojbf force-pushed the load-context-in-request-handler branch from 2b1c91f to 1df3065 Compare March 22, 2023 08:56
.changeset/twelve-cheetahs-drive.md Outdated Show resolved Hide resolved
.changeset/twelve-cheetahs-drive.md Outdated Show resolved Hide resolved
@kiliman
Copy link
Collaborator

kiliman commented Apr 26, 2023

I, too, would like to see the PR merged. I think it was an oversight in the initial implementation. The other handle*Request functions contain the context (as they came later).

@jacob-ebey jacob-ebey merged commit 98bdd4c into remix-run:dev Apr 26, 2023
@fernandojbf
Copy link
Contributor Author

Thank you 🎉

@jacob-ebey
Copy link
Member

Thank you 🎉

Thank YOU! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants