fix(dev): show first compilation error when build fails #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e81821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jacob-ebey
reviewed
Apr 26, 2023
| @@ -69,7 +73,7 @@ export let create = async (ctx: Context): Promise<Compiler> => { | |||
|
|
|||
| // css compilation | |||
| let css = await tasks.css; | |||
| if (!css.ok) throw css.error; | |||
| if (!css.ok) throw error ?? css.error; | |||
There was a problem hiding this comment.
Can this just be if (error) throw error? The error is always assigned, so if the thing you awaited above errors, it will be there, and if anything else errors, also throw. Gets us out of here quicker and avoids future work if we something at all fails.
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #
Testing Strategy: