liveReload: add hearbeat for keepalive #6904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the WebSocket connection from being closed due to inactivity when using a proxy like Cloudflare.
|
brophdawg11
added
package:dev
feat:dx
pcattori
approved these changes
Jul 21, 2023
ryanflorence
added a commit
that referenced
this pull request
Jul 21, 2023
This reverts commit 218c6eb.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the WebSocket connection from being closed due to inactivity when using a proxy like Cloudflare.
Testing Strategy:
Run a remix app in dev mode and load it via a Cloudflare tunnel:
npm run dev & cloudflared tunnel --url http://localhost:57763Now open the tunnel URL and wait 100 seconds. The socket connection will be closed and the page will reload.