Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: default to serverModuleFormat esm #6949

Merged
merged 25 commits into from
Aug 9, 2023
Merged

feat!: default to serverModuleFormat esm #6949

merged 25 commits into from
Aug 9, 2023

Conversation

jacob-ebey
Copy link
Member

feat: update remix-serve to use dynamic import to support esm and cjs

Closes: #

  • Docs
  • Tests

Testing Strategy:

feat: update remix-serve to use dynamic import to support esm and cjs
@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: fd1f59e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Major
@remix-run/serve Major
create-remix Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/css-bundle Major
@remix-run/deno Major
@remix-run/eslint-config Major
@remix-run/express Major
@remix-run/node Major
@remix-run/react Major
@remix-run/server-runtime Major
@remix-run/testing Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey added the v2 Issues related to v2 apis label Aug 2, 2023
@AlemTuzlak
Copy link
Contributor

@jacob-ebey Leaving the comment for you here too:
I found your culprit, in create-fixture.ts, in createFixtureProject:

await fse.copy(integrationTemplateDir, projectDir);

dies
It seems fse adds a drive at the start
if i do this:

await fse.copy(integrationTemplateDir.replace("C:\\", ""), projectDir);

it doesn't have two drives at the start

@jacob-ebey jacob-ebey merged commit 527a5d6 into dev Aug 9, 2023
9 checks passed
@jacob-ebey jacob-ebey deleted the v2_esm branch August 9, 2023 22:58
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 9, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev package:serve v2 Issues related to v2 apis
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants