fix(remix-dev): allow emitting serverBuildPath as cjs
#7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan McAnsh <[email protected]> (cherry picked from commit 63b5e5d)
|
mcansh
changed the title
serverBuildPath as cjs
MichaelDeBoey
requested review from
markdalgleish,
pcattori,
brophdawg11 and
jacob-ebey
|
Duplicate of #7180. |
ah, i did some searching for serverBuildPath in issues/prs, but never came across that one. nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Logan McAnsh [email protected]
(cherry picked from commit 63b5e5d)
same as #7348 but pointed to main
Closes: #
Testing Strategy: