Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle multiple "Set-Cookie" headers in unstable_vitePlugin dev #7843

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

nickprinsloo
Copy link
Contributor

Closes: #7837

  • Docs
  • Tests

Testing Strategy:

Added additional test to the existing integration test for the Vite Node adapter.

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: e202cd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 31, 2023

Hi @nickprinsloo,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@nickprinsloo nickprinsloo marked this pull request as draft October 31, 2023 15:56
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 31, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@nickprinsloo nickprinsloo marked this pull request as ready for review October 31, 2023 15:58
@nickprinsloo nickprinsloo changed the title fix: handle multiple "Set-Cookie" headers fix: handle multiple "Set-Cookie" headers in unstable_vitePlugin dev Oct 31, 2023
@markdalgleish
Copy link
Member

Thanks for the PR! I noticed the same issue has already fixed in solid-start's implementation in the time since we used their adapter as our initial starting point. I've updated your PR to use theirs instead to keep the two implementations closer. I've also made the ordering more explicit in the test.

@nickprinsloo
Copy link
Contributor Author

Great, makes sense. Thanks for taking a look.

@markdalgleish markdalgleish merged commit e3675c5 into remix-run:dev Nov 2, 2023
9 checks passed
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants