fix(vite): disable redundant copyPublicDir option

[markdalgleish]

Fixes #8023

From the changeset:

Fix redundant copying of assets from public directory in Vite build. This ensures that static assets aren't duplicated in the server build directory. This also fixes an issue where the build would break if assetsBuildDirectory was deeply nested within the public directory.

[changeset-bot]

🦋 Changeset detected

Latest commit: c8d9a50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/dev	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gustavopch]

I was loading custom fonts in my app/global.css like this:

@font-face {
  font-display: swap;
  font-family: 'Poppins';
  font-style: normal;
  font-weight: 500;
  src: url('/fonts/poppins-v19-latin-500.woff2') format('woff2');
}

The fonts were located in my project in the public/fonts folder, so with copyPublicDir: true, they would be copied to public/build/fonts. Turns out with copyPublicDir: false they fail to load in production because the output CSS tries to load them with a build/ prefix url('/build/fonts/poppins-v19-latin-500.woff2') and now they're not copied to there anymore. Note that in development they're still loaded from the right place, without this build/ prefix.

So either I'm loading the fonts wrong or there's another issue that's now surfaced with copyPublicDir: false.

As a workaround, I'm moving the fonts from public/fonts to app/fonts and using a relative import like url('./fonts/poppins-v19-latin-500.woff2'). Maybe that's just how it's supposed to be done anyway. If so, then it's worth mentioning this change in the migration doc.

[markdalgleish]

@gustavopch Your issue is an interesting one to me. I didn't realise that Vite rewrites references to files in your public directory when present in the CSS. Your fix of moving the file to the app directory is what I would have recommended, but I think this is highlighting a disconnect between the way the Remix compiler worked and the way Vite works when it comes to directory structure and public files. I might need to dig into this further.

[github-actions]

🤖 Hello there,

We just published version 2.3.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[markdalgleish]

@gustavopch I've opened a PR that will fix your issue: #8077. This means that the directory structure needs to change when using Vite so it's not a small change, but I'm glad this got picked up relatively early.

[github-actions]

🤖 Hello there,

We just published version 2.3.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!