Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite: exclude modules within .server directories from client build #8154

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Vite: exclude modules within .server directories from client build #8154

merged 2 commits into from
Nov 27, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Nov 27, 2023 •
edited
Loading

Previously, only files with a .server extension were excluded. Now, files (recursively) within a directory named .server are also excluded.

@pcattori pcattori changed the title Pedro/dot server Vite: exclude modules within .server directories from client build Nov 27, 2023
@pcattori
feat(vite): exclude modules within .server directories from client …
a5621bb 
…build

and vice versa for `.client` directories and server build
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9086da0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: a5621bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
integration-tests Minor
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit 2d3e1d8 into dev Nov 27, 2023
9 checks passed
@pcattori pcattori deleted the pedro/dot-server branch November 27, 2023 22:07
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 27, 2023
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🤖 Hello there,

We just published version 2.4.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Dec 13, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcattori @markdalgleish