fix (remix-serve): convert file url to path when loading source maps

[VHall1]

This PR fixes an issue where the leading slash on source map paths would cause remix-serve to crash when an error gets thrown on Windows.

Tested both on Windows and Mac.

Closes: 8309

[changeset-bot]

🦋 Changeset detected

Latest commit: 899e6b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/serve	Patch
@remix-run/dev	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @VHall1,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[kiliman]

Ugh. I should have tested my "fix" on Windows.

Seems like something that source-map-support should automatically handle.

I verified that url.fileURLToPath() works correctly on macOS and Windows. It even ignores the search param.

Thanks for fixing this.

[brophdawg11]

Thanks!

[brophdawg11]

Sorry for the accidental close - commented/closed this thinking I was on a different PR 🤦

[kiliman]

Ha, yeah. @brophdawg11 this fixes the source-map issue from the previous PR but now works on Windows (yeah, I should have tested it on Windows, primarily since it's path-related 😳)

[github-actions]

🤖 Hello there,

We just published version 2.4.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 2.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!