-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (remix-serve): fallback to default path if source maps aren't available when building stack trace #8446
fix (remix-serve): fallback to default path if source maps aren't available when building stack trace #8446
Conversation
🦋 Changeset detectedLatest commit: 27bf362 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Not sure if this warrants a version bump, but happy to add a changeset if it does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
yeah - since this changes source code, it should have a changeset. Would you mind pointing the PR to to |
yep, sounds good to me! Will add the changeset and point to the correct branch later today. |
88f9ca3
to
9ba0cae
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
9ba0cae
to
fab00a0
Compare
sorry for the mess, should be pointing to dev now. |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Another update to source map loading. This should resolve issues where people reported getting server crashes when they had source maps disabled or when errors were being thrown by 3rd party packages (since source maps aren't available for those). All this does really is check that the file exists before loading it, and returning null if it doesn't (using the original path as a fallback). Mostly based on the patch suggested here: #8309 (comment)
Testing:
3rd party error (tiny-invariant)
generic error
generic error after manually deleting source map
Closes: #8309