Add mode field into generated vite server build #8539
Conversation
🦋 Changeset detectedLatest commit: ed19696 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -466,6 +467,7 @@ export const remixVitePlugin: RemixVitePlugin = (options = {}) => { | |||
| )};`; | |||
| }) | |||
| .join("\n")} | |||
| export const mode = ${JSON.stringify(viteConfig.mode)}; | |||
There was a problem hiding this comment.
Can we add a comment to remove this once we deprecated and remove the old compiler? This field exists only as a way to address issues with the old compiler and isn't used for Vite.
There was a problem hiding this comment.
Maybe we should have a board for all the things we want to deprecate/remove so we don't forget to do those when we bump a major version
There was a problem hiding this comment.
yeah I guess we'll want to deprecate after we stabilize vite and officially mark the old compiler as deprecated and remove it in v3?
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
Reported in discord - TS was throwing an error in the vite express template if you use a
server.ts