Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin): remove directoy check on route file #8792

Closed
wants to merge 1 commit into from

Conversation

lfantone
Copy link
Contributor

This PR tries to solve this issue

What I did was to remove the check against the appDirectory, the change look safe on the test I run which is based in the reproduction case submitted in the issue. But I don't have the background to know if that check is really needed.
Let me know and I can update the PR 😄

Copy link

changeset-bot bot commented Feb 19, 2024

🦋 Changeset detected

Latest commit: 6ac8b16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jrestall
Copy link
Contributor

Nice this would also fix #6711 (comment)

@pcattori
Copy link
Contributor

Superceded by #8795

Thanks @lfantone for filing the issue and putting up a PR! 🙏 We want this bug fix to land in time for out 2.7 release and rebasing PRs onto the release branch via GitHub UI is messy... So instead, I recreated this PR in #8795 and tagged you as a co-author in that commit.

@pcattori pcattori closed this Feb 19, 2024
@lfantone lfantone deleted the dev branch February 20, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants