Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: add checksum sample app coded in Groovy and Scala #1205

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Manual: add checksum sample app coded in Groovy and Scala #1205

merged 1 commit into from
Oct 7, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 6, 2020

This PR adds checksum sample app coded in Groovy and Scala.

For Groovy language, I decided to add a Groovy scipt.
Should we add Groovy example with class, too? What do you think?

@codecov-io
Copy link

codecov-io commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@aba5a8e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1205   +/-   ##
=========================================
  Coverage          ?   94.30%           
  Complexity        ?      455           
=========================================
  Files             ?        2           
  Lines             ?     6676           
  Branches          ?     1795           
=========================================
  Hits              ?     6296           
  Misses            ?      102           
  Partials          ?      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba5a8e...25d3c23. Read the comment docs.

@remkop remkop added this to the 4.6 milestone Oct 7, 2020
@remkop remkop merged commit ddf823a into remkop:master Oct 7, 2020
remkop added a commit that referenced this pull request Oct 8, 2020
remkop added a commit that referenced this pull request Oct 8, 2020
@remkop
Copy link
Owner

remkop commented Oct 8, 2020

Thank you!
I went ahead and added a Groovy class example, it is worth doing so because it has some significant differences with Groovy script.

Some small details I changed:

  • I used version = "checksum 4.0" throughout; there is nothing in the examples that is tied it to the latest picocli version, but since it uses the execute API, this example requires picocli 4.0 at a minimum
  • I replaced the single unicode character with ... (three dots) to be sure it can be rendered in any terminal with any character encoding and code page

Overall this looks very nice now!
It showcases how picocli can be used by all these JVM languages in a very natural way.
Thank you again!

@deining deining deleted the Checksum_Sample_Scala_Groovy branch October 11, 2020 07:02
remkop added a commit that referenced this pull request Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants