Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: Extending chapter 28.3 'Testing the Exit Code' #1342

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Manual: Extending chapter 28.3 'Testing the Exit Code' #1342

merged 1 commit into from
Mar 9, 2021

Conversation

deining
Copy link
Contributor

@deining deining commented Mar 7, 2021

Can you do me a favor and regenerate the html docs, please? Thanks.

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #1342 (c6b893c) into master (dd2d967) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1342   +/-   ##
=========================================
  Coverage     93.76%   93.76%           
  Complexity      474      474           
=========================================
  Files             2        2           
  Lines          6961     6961           
  Branches       1869     1869           
=========================================
  Hits           6527     6527           
  Misses          147      147           
  Partials        287      287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2d967...51be0bf. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Mar 8, 2021

Hi @deining, I’ll try to get to this in the next few days.

I was planning to publish the manual with the next release.
The only thing outstanding for the next release is #1322 (and that’s not really a showstopper, it’s just something I’d like to get out of the way, and doing a release is the best/only way to test it...)

Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these improvements! Good to know there are lots of options for testing! :-)

I added some comments.

docs/index.adoc Outdated Show resolved Hide resolved
docs/index.adoc Outdated Show resolved Hide resolved
@deining deining requested a review from remkop March 8, 2021 09:20
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Thanks also for explaining about the description lists. I didn't know that one. :-)

I will merge this now, and update the release notes later.
This will be published when I get around to doing the release. (Still looking at #1322).

Many thanks!

@remkop remkop merged commit 7438ef4 into remkop:master Mar 9, 2021
@deining deining deleted the test_exitcode branch March 11, 2021 09:00
remkop added a commit that referenced this pull request Mar 18, 2021
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…he Exit Code' improvement"

This reverts commit acfadf7.
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…he Exit Code' improvement"

This reverts commit acfadf7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants