Remove execution and extension characters in the generated autocomplete script #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkop
added
theme: auto-completion
|
@andreaTP Thank you for the contribution! |
|
Merged. Thank you for the contribution! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the amazing project and all the effort in it @remkop !
This is a follow up from an issue experienced in the Keycloak project:
keycloak/keycloak#8875
Sorry for directly opening a PR instead of an Issue, but I do believe that this change is more self-explanatory in code 🙂
Rationale:
./breaks the autocomplete script on ZSH.bashand.shautocompletion extensions are always automatically generatedSanitizing the internally used
scriptNamesounds like a first step in the right direction, wdyt?