Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate TravisBuddy #1107

Closed
wants to merge 1 commit into from
Closed

Integrate TravisBuddy #1107

wants to merge 1 commit into from

Conversation

bluzi
Copy link

@bluzi bluzi commented Dec 2, 2017

TravisBuddy will comment on pull requests in your public repository everytime a test failed in one of them. The comment will include only the part of the build log that applies to your testing framework, so your contirbutors won't have to enter Travis's website and search the long and annoying build log for the reason the tests failed.

Here's an example: bluzi/static-server#1

TravisBuddy will comment on pull requests in your public repository everytime a test failed in one of them. The comment will include only the part of the build log that applies to your testing framework, so your contirbutors won't have to enter Travis's website and search the long and annoying build log for the reason the tests failed.

Here's an example: bluzi/express#1
@raucao
Copy link
Member

raucao commented Dec 2, 2017

We don't really need a hosted service to add information about something that GitHub already adds. If you think that TravisBuddy actually parses Jaribu output in a nice way, then maybe let this pull request fail as a demo?

@bluzi
Copy link
Author

bluzi commented Dec 2, 2017

Hey @skddc!

Unfortunately TravisBuddy support prettifying test logs at the moment, but it's a goal we're working on.
However, TravisBuddy adds information beyond what GitHub supports - While GitHub only indicates whether the checks failed or succeeded, TravisBuddy imminently presents the logs, and makes it easier for contributors to identify what's wrong with their changes.

Here's an example from one of my repositories, where TravisBuddy's comment made the contributor easily see what breaks the tests, it saves me the effort of commenting myself, because some contributors just won't notice the tests failed or just won't understand why, because the log is too complicated.
bluzi/name-db#469

However, if you feel like it's not necessary here, feel free to close this PR :)

@raucao
Copy link
Member

raucao commented Dec 2, 2017

Ok, so it doesn't work here, because the output would contain pages upon pages of log before the failure. I'll close the PR then. Thanks.

@raucao raucao closed this Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants