Mark library as #![no_std]
#15
Conversation
|
Ah yes this would also make this library incompatible with 1.17.0 (which CI has notified me). While possible to work around if it's ok it's probably best to simply raise the rustc requirement. |
|
That is fine by me, as long as this doesn't affect "normal" users. I think you have sufficiently commented this in Raising the rustc version is fine, 1.17 is 3 years old. Even Debian oldstable ships 1.34. |
|
Ok great! I've pushed a commit to drop 1.17.0 from CI. And yeah the intention here is that the libstd integrate goop has zero impact on day-to-day users. Crates like Otherwise the changes here are sort of the standard bits for having a |
| [dependencies] | ||
| # Internal features, only used when building as part of libstd, not part of the | ||
| # stable interface of this crate. | ||
| core = { version = '1.0.0', optional = true, package = 'rustc-std-workspace-core' } |
There was a problem hiding this comment.
IIUC This needs the rename-dependency feature which makes the whole manifest unreadable until 1.31
Additionally also enable this library to be included into the standard library itself with some `[dependencies]` and `[features]` voodoo. My hope is to eventually enable the `backtrace` crate to depend on the `gimli` crate for parsing DWARF information and symbolizing backtraces. DWARF info in objects may be compressed though, and most zlib-related crates use this crate! As a result if libstd is going to be decompressing object files, we'll need to include this crate in the standard library build itself.
Additionally also enable this library to be included into the standard
library itself with some
[dependencies]and[features]voodoo. Myhope is to eventually enable the
backtracecrate to depend on thegimlicrate for parsing DWARF information and symbolizing backtraces.DWARF info in objects may be compressed though, and most zlib-related
crates use this crate! As a result if libstd is going to be
decompressing object files, we'll need to include this crate in the
standard library build itself.
If you've got any questions about this just let me know! I know it's a
bit odd, but unfortunately this is "as nice as it can be" for now at
least.