Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backspace not working well with characters for createTextMask #27

Closed
1 of 6 tasks
mingca opened this issue Apr 1, 2018 · 4 comments
Closed
1 of 6 tasks

Backspace not working well with characters for createTextMask #27

mingca opened this issue Apr 1, 2018 · 4 comments
Labels
bug Something isn't working text mask Refers to the `createTextMask`

Comments

@mingca
Copy link

mingca commented Apr 1, 2018

What are you reporting?

  • Bug
  • Feature request
  • Code refactor
  • Continuous Integration (CI) improvement
  • Changes in documentation (docs)
  • Other (describe)

What is the current behavior?

'+1 (999) 999-9999 x99999' - I can't remove x with backspace.

What is the expected behavior?

Should able to remove x with backspace.

Sandbox Link

What's your environment?

Mac Os high sierra 10.13.3

Other information
@renato-bohler
Copy link
Owner

renato-bohler commented Apr 1, 2018 •
edited
Loading

What is the pattern for the mask you've created?

If the pattern is '+1 (999) 999-9999 x99999', you really shoudn't be able to delete the x character, because those chars on the pattern that aren't defined in maskDefinitions are considered mask characters (such as parenthesis, space and dash on this example).

A sandbox would be greatly appreciated.

@renato-bohler
Copy link
Owner

Oh, I think I get it now. The caret position should isn't being correctly controlled on this situation.

issue 2

@mingca
Copy link
Author

mingca commented Apr 2, 2018

Thanks for your quick response. It's exactly what I faced today. So I can't remove x and the number before x by backspace. It's not good UX, I think.

@renato-bohler renato-bohler added bug Something isn't working text mask Refers to the `createTextMask` labels Apr 2, 2018
renato-bohler added a commit that referenced this issue May 5, 2018
@renato-bohler
fix(createTextMask): fixes backspace not controlling caret position c…
4efad32 
…orrectly on some cases

re #27
@renato-bohler renato-bohler mentioned this issue May 5, 2018
Merged
renato-bohler added a commit that referenced this issue May 5, 2018
@renato-bohler
chore(release): 1.1.1 [skip ci]
a0efb8e 
<a name="1.1.1"></a>
## [1.1.1](v1.1.0...v1.1.1) (2018-05-05)

### Bug Fixes

* **createTextMask:** fixes backspace not controlling caret position correctly on some cases ([4efad32](4efad32)), closes [#27](#27)
@renato-bohler
Copy link
Owner

Closed by #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working text mask Refers to the `createTextMask`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mingca @renato-bohler