Add support for specifying credentials #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianks All for this But I think you forgot to pass the opts object through to the storage initialization ? |
|
Finally, fixed. @DanielASAndrews @renchap |
renchap
requested changes
Apr 1, 2020
test/create_test_environment.sh
Outdated
| @@ -73,7 +79,7 @@ gcloud beta billing projects link $GOOGLE_CLOUD_PROJECT --billing-account=$GOOGL | |||
|
|
|||
| gcloud iam service-accounts create $GCS_SA \ | |||
| --project=$GOOGLE_CLOUD_PROJECT \ | |||
| --display-name $GCS_SA | |||
| --display-name $GCS_SA || true | |||
There was a problem hiding this comment.
I would prefer to not use || true here but check for the specific error / error code.
If not possible, I would just abort, the user can do it manually if she has a special case
test/create_test_environment.sh
Outdated
| @@ -58,7 +58,13 @@ fi | |||
| # Display every command executed from now | |||
| set -x | |||
|
|
|||
| gcloud projects create $GOOGLE_CLOUD_PROJECT | |||
| gcloud projects create $GOOGLE_CLOUD_PROJECT || read -p "Looks like this service accounts exists. If so, continue? (y/n)? " CONT | |||
There was a problem hiding this comment.
Does this command return an error when a service account already exists, or the project? I am not really keen to add complexity in this script and handle the various cases, it is meant as a simple helper to set up the test environment + documentation on how to do so manually if needed.
|
I just removed the diff @renchap |
|
Thanks! I will release 3.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
credentialsoption to be specified for Storage. This way, we do not have to use global credentials.