Skip to content

Commit

Permalink
Made ecrecover implementation trait public (openethereum#11188)
Browse files Browse the repository at this point in the history
* Made ecrecover Implementation trait public

* Make all builtin contract types public

This ensure the API is consistent in terms of visibility.
  • Loading branch information
tolbrino authored and renlord committed Oct 22, 2019
1 parent bea4438 commit 30144ef
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions ethcore/builtin/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ use parity_crypto::digest;
use eip_152::compress;

/// Native implementation of a built-in contract.
trait Implementation: Send + Sync {
pub trait Implementation: Send + Sync {
/// execute this built-in on the given input, writing to the given output.
fn execute(&self, input: &[u8], output: &mut BytesRef) -> Result<(), &'static str>;
}
Expand Down Expand Up @@ -305,31 +305,31 @@ fn ethereum_builtin(name: &str) -> Result<Box<dyn Implementation>, EthcoreError>
// - blake2_f (The Blake2 compression function F, EIP-152)

#[derive(Debug)]
struct Identity;
pub struct Identity;

#[derive(Debug)]
struct EcRecover;
pub struct EcRecover;

#[derive(Debug)]
struct Sha256;
pub struct Sha256;

#[derive(Debug)]
struct Ripemd160;
pub struct Ripemd160;

#[derive(Debug)]
struct Modexp;
pub struct Modexp;

#[derive(Debug)]
struct Bn128Add;
pub struct Bn128Add;

#[derive(Debug)]
struct Bn128Mul;
pub struct Bn128Mul;

#[derive(Debug)]
struct Bn128Pairing;
pub struct Bn128Pairing;

#[derive(Debug)]
struct Blake2F;
pub struct Blake2F;

impl Implementation for Identity {
fn execute(&self, input: &[u8], output: &mut BytesRef) -> Result<(), &'static str> {
Expand Down

0 comments on commit 30144ef

Please sign in to comment.