Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include depName in changelog release name patterns #30297

Closed
rarkins opened this issue Jul 22, 2024 · 2 comments · Fixed by #30395
Closed

Include depName in changelog release name patterns #30297

rarkins opened this issue Jul 22, 2024 · 2 comments · Fixed by #30395
Labels
core:changelogs Related to changelogs/release notes fetching priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jul 22, 2024

Describe the proposed change(s).

Currently we look for github releases either by version (e.g. 1.0.0) or packageName-release, e.g. (foo-1.0.0). We should include depName in this search too.

Discussion with reproduction: #29943 (test-dep update to v1.2.0)
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:changelogs Related to changelogs/release notes fetching labels Jul 22, 2024
usmonster added a commit to usmonster/renovate that referenced this issue Jul 26, 2024
@usmonster
feat(changelogs): Include depName in release name patterns
acf6b58 
Closes renovatebot#30297
@usmonster usmonster mentioned this issue Jul 26, 2024
Merged
6 tasks
@usmonster
Copy link
Contributor

Proposed fix: #30395.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core:changelogs Related to changelogs/release notes fetching priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(changelogs): Include depName in release name patterns usmonster/renovate
3 participants
@usmonster @rarkins @renovate-release