Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gitlab): Add gitLabIgnoreApprovals option #10981

Merged
merged 18 commits into from
Aug 4, 2021
Merged

feat(gitlab): Add gitLabIgnoreApprovals option #10981

merged 18 commits into from
Aug 4, 2021

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 27, 2021 •
edited
Loading

Changes:

Context:

Closes #6577

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as ready for review July 27, 2021 10:17
@zharinov
Copy link
Collaborator Author

Run on real repository. API calls are successful, though can't setup further automerge capability for GitLab

rarkins
rarkins requested changes Jul 27, 2021
View reviewed changes
lib/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/workers/pr/index.ts Outdated Show resolved Hide resolved
Sergei Zharinov added 3 commits July 27, 2021 13:44
HonkingGoose
HonkingGoose suggested changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording changes to the docs.

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jul 29, 2021
View reviewed changes
rarkins
rarkins previously approved these changes Jul 30, 2021
View reviewed changes
@zharinov zharinov mentioned this pull request Aug 2, 2021
Closed
6 tasks
Sergei Zharinov added 2 commits August 3, 2021 08:16
rarkins
rarkins previously approved these changes Aug 3, 2021
View reviewed changes
@rarkins rarkins requested a review from viceice August 3, 2021 07:48
@rarkins rarkins mentioned this pull request Aug 3, 2021
Closed
HonkingGoose
HonkingGoose suggested changes Aug 4, 2021
View reviewed changes
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice August 4, 2021 07:22
@rarkins rarkins merged commit 9d580e0 into renovatebot:main Aug 4, 2021
@rarkins rarkins deleted the feat/gitlab-ignore-approvals branch August 4, 2021 07:49
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.66.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cjpearson cjpearson mentioned this pull request Aug 5, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cjpearson cjpearson cjpearson left review comments

@HonkingGoose HonkingGoose HonkingGoose requested changes

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove GitLab approval rules when automerging
6 participants
@zharinov @renovate-release @viceice @cjpearson @rarkins @HonkingGoose