Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace as with partial #20252

Merged
merged 3 commits into from
Feb 7, 2023
Merged

test: replace as with partial #20252

merged 3 commits into from
Feb 7, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • replace as with partial and in some cases remove them altogether as the assertion isn't necessary

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review February 7, 2023 05:32
viceice
viceice approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's more Todo in follow up PR 😅

lib/workers/repository/update/branch/index.spec.ts Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) February 7, 2023 11:17
@viceice viceice merged commit 7ff4b53 into renovatebot:main Feb 7, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.127.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RahulGautamSingh @renovate-release @viceice