Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace as assertions #20527

Merged
merged 9 commits into from
Feb 25, 2023
Merged

test: replace as assertions #20527

merged 9 commits into from
Feb 25, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Feb 20, 2023 •
edited by viceice
Loading

Changes

  1. Replace as assertions with partial for BranchUpgradeConfig

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Feb 21, 2023
View reviewed changes
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.spec.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Feb 23, 2023

sounds good, go ahead with 2. but make small PR's for easier and faster review.

@RahulGautamSingh RahulGautamSingh mentioned this pull request Feb 24, 2023
Merged
6 tasks
@RahulGautamSingh
Copy link
Collaborator Author

Blocked by #20618

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Feb 24, 2023 •
edited
Loading

sounds good, go ahead with 2. but make small PR's for easier and faster review.

Tracking it here #20619

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review February 25, 2023 12:03
@viceice viceice added this pull request to the merge queue Feb 25, 2023
Merged via the queue into renovatebot:main with commit acc6c59 Feb 25, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.152.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RahulGautamSingh @viceice @renovate-release