Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio Code.edit.py blows up paths with spaces in them #79

Closed
coldacid opened this issue Mar 22, 2022 · 4 comments · Fixed by #80
Closed

Visual Studio Code.edit.py blows up paths with spaces in them #79

coldacid opened this issue Mar 22, 2022 · 4 comments · Fixed by #80
Labels
bug Something isn't working
Milestone

Comments

@coldacid
Copy link

I'm not sure if this is an issue with the editor script or if it's a problem with Ren'Py itself, but it makes things a bit frustrating when working from the launcher.

@LuqueDaniel
Copy link
Member

Can you provide more information? OS and error log.

@coldacid
Copy link
Author

No error log, but OS is Windows 10. But here's essentially what happens:

My project is in "C:\Users\username\Documents\Ren'Py Projects\Project Name". Ren'Py SDK is in "C:\Tools\renpy-7.4.11-sdk". I click the link in the Ren'Py Launcher to open script.rpy in my project, and what I get in VS Code are three tabs to non-existent files "C:\Users\username\Documents\Ren'Py", "C:\Tools\renpy-7.4.11-sdk\Projects\Project", and "C:\Tools\renpy-7.4.11-sdk\Name\game\script.rpy" instead of "C:\Users\username\Documents\Ren'Py Projects\Project Name\game\script.rpy".

I was able to catch the command line for the Code.exe process with Process Explorer: "C:\Program Files\Microsoft VS Code\Code.exe" -g C:\Users\username\Documents\Ren'Py Projects\Project Name\game\script.rpy showing that the file name is not quoted, causing it to be broken into multiple command line arguments.

When using the "Open project" link in Ren'Py Launcher, the process command line is: "C:\Program Files\Microsoft VS Code\Code.exe" -g "C:\Users\username\Documents\Ren'Py Projects\Project Name" instead, showing that in this situation the project directory is properly quoted.

@LuqueDaniel
Copy link
Member

@coldacid can you test #80?

@coldacid
Copy link
Author

@LuqueDaniel works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants