Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LockHeldByMe compilation error against pg17 #414

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Melkij
Copy link
Collaborator

@Melkij Melkij commented Jul 30, 2024

commit 0cecc908e9749101b5e93ba58d76a62c9f226f9e in postgresql changed the signature of the LockHeldByMe function, which caused the pg_repack build to fail.

Actually, the orstronger argument is not important for us, since we need the strictest AccessExclusiveLock lock. But I can simplify the code a little by using a more appropriate new CheckRelationOidLockedByMe function.

commit 0cecc908e9749101b5e93ba58d76a62c9f226f9e in postgresql changed the signature of the LockHeldByMe function, which caused the pg_repack build to fail.

Actually, the orstronger argument is not important for us, since we need the strictest AccessExclusiveLock lock. But I can simplify the code a little by using a more appropriate new CheckRelationOidLockedByMe function.
@Melkij Melkij merged commit d63fd39 into reorg:master Jul 31, 2024
10 checks passed
@Melkij
Copy link
Collaborator Author

Melkij commented Jul 31, 2024

thanks, merged

@Melkij Melkij deleted the fix_pg17_LockHeldByMe_changed branch July 31, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants