Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppKit update: Updating the code references to reown #5

Merged
merged 55 commits into from
Sep 13, 2024
Merged

Conversation

rohit-710
Copy link
Collaborator

@rohit-710 rohit-710 commented Sep 9, 2024

Description:

Important: Please do not merge this PR as I will be updating some more code references.

  1. All of the code references for Next, React, Vue and Javascript have been updated.
  2. The "Onboarding" section that contains the doc pages for "Emails & Socials" and "Smart Accounts" have also been updated.
  3. The "Transactions" section that contains the doc pages for "On-Ramp" and "Swaps" have been updated.
  4. This includes the packages to install/import, the minor code changes, interface changes, params changes, etc.
  5. I have also updated the Solana code to work with reorg.

Tests:

  1. I tried testing the code by first installing the test packages here.
  2. Then I tried to run the code snippets and verify it by building a simple React app locally.
  3. The docs were tested locally.

Direct Links (please check the docs)

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reown-docs ✅ Ready (Inspect) Visit Preview 3 resolved Sep 13, 2024 6:18am

@rohit-710 rohit-710 changed the title AppKit update: Updating the React code references to reorg AppKit update: Updating the React code references to reown Sep 10, 2024
docs/appkit/features/swaps.mdx Outdated Show resolved Hide resolved
@@ -326,7 +326,7 @@ import credentialsProvider from 'next-auth/providers/credentials'
import { getCsrfToken } from 'next-auth/react'
import NextAuth from 'next-auth/next'

import type { SIWESession } from '@web3modal/siwe'
import type { SIWESession } from '@reown/appkit-siwe'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is SIWE another package?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how they are structuring it - as per the info provided by AppKit team.

Copy link

vercel bot commented Sep 13, 2024

@llbartekll is attempting to deploy a commit to the WalletConnect Team on Vercel.

To accomplish this, @llbartekll needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@rohit-710 rohit-710 merged commit eec66ba into main Sep 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants