-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externalize pypi map into a ro sqlite database #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
reviewed
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ tree result
result
├── bin
│ ├── gen_pypi_map
│ └── upm
└── pypi_map.sqlite
Do we need the bin/gen_pypi_map file? It is pretty big.
That's only used for dev. I can look into getting rid of it. Probably a config to the buildGoModule call. |
ryantm
requested changes
Jul 24, 2023
Co-authored-by: Ryan Mulligan <[email protected]>
Co-authored-by: Ryan Mulligan <[email protected]>
ryantm
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Having to load in the large maps within pypi_map.gen.go file into memory at start is causing upm 0.2 - 0.3 seconds.
Context: https://github.com/replit/goval/pull/9988#issuecomment-1646262367
We can eliminate this slowdown by externalizing this data into a lightweight database.
Changes
Operations to be re-tested:
Performance enhancement should affect all languages and all operations.
Testing
nix build
mkdir play; cd play
main.py
containing:time ../result/bin/upm lock
time ../result/bin/upm guess -f
If you compare to the version in head, should see a sizable decrease in run time. In my local testing I saw ~200x for lock (when no op) and ~60x for guess.
Also, re-test
upm guess -f -l python
andupm search -l python <query>
to make sure those still work.